pty: immediately render after a period of inactivity #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code waits for 30ms after reading new data to refresh the screen in order to batch input together. This reduces the number of refreshes, but also adds perceptible latency as keystrokes will only get visual feedback after a 30 ms delay. Improve this by immediately refreshing if more than 30ms have already passed since the last refresh. That way punctual events like keystrokes get immediate feedback, while heavier input still gets batched together.
|
Hey @Gnurou - I'm very happy to see this. I'm a little backed up at the moment, so will try to take a look in the next few days. For now I've approved the CI to run in case there are some small issues to address. |
|
Looks great, thanks! |
|
@Gnurou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code waits for 30ms after reading new data to refresh the
screen in order to batch input together. This reduces the number of
refreshes, but also adds perceptible latency as keystrokes will only get
visual feedback after a 30 ms delay.
Improve this by immediately refreshing if more than 30ms have already
passed since the last refresh. That way punctual events like keystrokes
get immediate feedback, while heavier input still gets batched together.